WordPress MU

I created a test blog account. But in the email that asks me to activate my blog has following link:

http://testblog.mysite.comwp-activate.php?key=dd2e048f14661c98

It's missing a "/" before wp-activate.php

Maybe someone can enter the bug.

Works on my r725 install.

The problem I am seeing happens on 08-24 nightly build. I just upgraded to it two days ago. My old version was about 4-month old.

I am trying to locate the code that sends the email. If I find it, I can manually change it.

It's at the end of the wp-includes/wpmu-functions.php

I'd post mine but it's been heavily modified to get stats to work.

I got it.

function wpmu_signup_blog_notification($domain, $path, $title, $user, $user_email, $key, $meta = '')

I added "/" to following section

if( constant( "VHOST" ) == 'no' ) {
$activate_url = "http://" . $current_site->domain . $current_site->path . "wp-activate.php?key=$key";
} else {
$activate_url = "http://{$domain}{$path}/wp-activate.php?key=$key";
}

It was like this
"http://{$domain}{$path}wp-activate.php?key=$key";

Thanks for drmike's help.

It's me again.
I upgraded my site last night to the latest build. I noticed that the same problem still existed. Has anyone reported this problem to the developers? Or only me have this issue?

Thanks

As I understand it (http://trac.mu.wordpress.org/browser/trunk), only donncha has access to change the codebase. WPMU is read-only source, not open-source.

Unless *you* logged it on http://trac.mu.wordpress.org/report/1 then I doubt it has reported.

read-only source? So, when was the last time you changed code directly in the codebase of PhpMyAdmin, the Linux Kernel, Mozilla, phpbb, or any other open source project? They can't be open source either can they? It's all been a conspiracy!

I think MrJ is saying that the SNV is cloded source as it we can't put in our own code fixes.

I could have sworn that the path record has a trailing slash already in there. I know I'm not having any issues with folks not signing up. I have VHost turned on here and all path is is just a slash.

mshao - the latest build or the latest nightly? I'm running RC4 and don't have that problem.

See, it's a bug and suitable for trac only if more than one user can verify and replicate the problem. ;) And open source doesn't mean anybody can work on it, just that the source of the project is distributed freely and you're free to modify it as you like.

Fair point about the other projects being closed for contribution yet open source. I'll have a look around for a typology of open source projects.

I presume at least one of those is like WPMU in having just one person with commit access?

Donncha, you are doing a great job, by the way, I only wonder whether we could do more as a team. (It may also create resiliancy in the process should you be on vacation, or be unavailable).

I'm particularly cautious about the approach that people randomly modify their own installs and I suspect that the community may have much to gain if the changes commonly made were centrally distributed.

In particular I dislike the idea of changing any of the distribution files. I'd favour a clean distinction between the core files of WPMU and those that I add or customise. Needing to change a core file to change the default blog links just seems wrong.

mshao - Do you have the line "RewriteBase /" in your htaccess?

mrjcleaver- From http://www.gnu.org/

"What is Free Software?

Free software'' is a matter of liberty, not price. To understand the concept, you should think of free'' as in free speech,'' not as in free beer.''

Free software is a matter of the users' freedom to run, copy, distribute, study, change and improve the software. More precisely, it refers to four kinds of freedom, for the users of the software:

* The freedom to run the program, for any purpose (freedom 0).
* The freedom to study how the program works, and adapt it to your needs (freedom 1). Access to the source code is a precondition for this.
* The freedom to redistribute copies so you can help your neighbor (freedom 2).
* The freedom to improve the program, and release your improvements to the public, so that the whole community benefits (freedom 3). Access to the source code is a precondition for this."

And by access to the source code, both WP and WPMU give anyone and everyone access. Doesn't mean *your* changes (or mine, or anyone's) will be made into a new release on any given project.

Also, here's some light reading:
http://codex.wordpress.org/GPL

This is what WP/WPMU is licensed under. The term "open source" has really morphed, and is not now (as I see it) interchangeable with the above.

"I'm particularly cautious about the approach that people randomly modify their own installs and I suspect that the community may have much to gain if the changes commonly made were centrally distributed."

That's why people who are making changes to the code to do specific things are encouraged to make PLUGINS. So there *is* a clear distinction between core files and customizations.

Yes, I do. Here is my .htaccess. Last time I did the upgrade was 09/04, the issues is still there. I don't unnderstand why RC4 doesn't have it. Thanks.

RewriteEngine On
RewriteBase /
# Rewrite http://www.domain.com to domain.com
RewriteCond %{HTTP_HOST} ^www\.(.*)
RewriteRule ^(.*) http://%1/$1 [R,L]

#uploaded files
RewriteRule ^(.*)?/?files/(.*) wp-content/blogs.php?file=$2 [L]

RewriteCond %{REQUEST_FILENAME} -f [OR]
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule . - [L]
RewriteRule ^([_0-9a-zA-Z-]+/)?(wp-.*) $2 [L]
RewriteRule ^([_0-9a-zA-Z-]+/)?(.*\.php)$ $2 [L]
RewriteRule . index.php [L]

php_value upload_max_filesize 2M