The MU forums have moved to WordPress.org

HTTP hardcoded in wpmu core files (18 posts)

  1. jamk
    Member
    Posted 14 years ago #

    Hi all!

    After making my WPMU's login and admin side secure via https I noticed that "http" is hardcoded in at least one place where it hurts.

    In "Admin -> Blogs" all the "Backend" buttons which take you directly to the dashboard of the chosen blog, the link has a "http" which is hardcoded in the core php file. This is the exactly location:

    wp-admin/wpmu-blogs.php, row 475

    $controlActions[]	= "<a href='http://{$blog['domain']}{$blog['path']}wp-admin/' class='edit'>" . __('Backend') . '</a>';

    That should be changed to some selector which sniffs whether you are using http or https in the next wpmu release!

  2. andrea_r
    Moderator
    Posted 14 years ago #

    file a trac ticket: http://mu.wordpress.org

    use the same login/pass as you have here.

  3. jamk
    Member
    Posted 14 years ago #

    Filed it!

    http://trac.mu.wordpress.org/ticket/1177

    I hope to see it fixed in future releases - have to have them core files modified :)

  4. SteveAtty
    Member
    Posted 14 years ago #

    Is this actually a WP fix rather than WPMU fix though?

    I'm not sure how they're going to handle merging the two tracs as they merge the code lines.

  5. andrea_r
    Moderator
    Posted 14 years ago #

    Very very carefully.

    (with conflicting items, they'll just pick one)

  6. jamk
    Member
    Posted 14 years ago #

    I'd say it's more WPMU fix than WP, since it's located in wpmu-blogs.php.

    Unless you're referring to the merge of WPMU and WP in 2.9. Or is this just a bs rumor? :P

  7. SteveAtty
    Member
    Posted 14 years ago #

    I don't think bs rumour is the way to describe it, I think its going to happen but if it will be in 2.9 or if 2.9 will be some sort of hybrid I don't know.

    I've got a admin.css issue that I've not raised as a trac on WPMU because its in the WP css file but I can't get into the WP trac and I've asked questions on how to do it but the WP forums are so awash with noise that stuff like that gets lost.

  8. jamk
    Member
    Posted 14 years ago #

    Awesome. Donncha already fixed the bug and even spotted same bug in the "Only showing first 5 users." bit of the same php-file. :)

    http://trac.mu.wordpress.org/changeset/2028

  9. SteveAtty
    Member
    Posted 14 years ago #

    That's good.

  10. andrea_r
    Moderator
    Posted 14 years ago #

    Merge is for 3.0. No rumor. :P Everyone is trying to get 2.9 released first.

    @steve - WP trac should let you login with the same info as here.

  11. SteveAtty
    Member
    Posted 14 years ago #

    Andrea, I finally got WP trac to recognise my userID and password that worked fine for the WP forums and created a ticket.

    Is there a proper discussion anywhere about what the merge will mean to us WPMU people?

  12. andrea_r
    Moderator
    Posted 14 years ago #

    Not yet.

    But generally, the focus is on making sure current MU users will be able to upgrade to 3.0 and have their site work as usual. If you saw Ron's post back in October on the blog, he showed how it's definitely possible without a ton of work.

    So.. in terms of what it will mean? Not much, really. The upgrade will just be pointed to WordPress and it won't be called MU anymore. That's pretty much it.

    (and then, faster dev turnaround, more people working in it... you know, good stuff...)

  13. SteveAtty
    Member
    Posted 14 years ago #

    Well I was hoping that would be the case ;-)

  14. wpmuguru
    Member
    Posted 14 years ago #

    The type of things that have to be looked at are the duplicate functions - ex. wp_create_user & wpmu_create_user: Both take the same parameters but don't do exactly the same thing. And as of 2.8.4 wp_create_user accepted email addresses as a valid username while wpmu_create_user did not.

    There are other things beside functions, but pretty well everything falls in the category of nuance. I've been expecting since May that existing MU users will gain a bit of functionality out of the merge.

  15. jamk
    Member
    Posted 14 years ago #

    Well I'm definately looking for some of those phat stuff they're having in wordpress.com to us "regular" WPMU users. Let's hope that the merge will bring 'em... :)

  16. andrea_r
    Moderator
    Posted 14 years ago #

    Lots of it has been released already.... :)

  17. pbais
    Member
    Posted 14 years ago #

    .....
    I noticed that "http" is hardcoded in at least one place where it hurts.

    In "Admin -> Blogs" all the "Backend" buttons which take you directly to the dashboard of the chosen blog, the link has a "http" which is hardcoded in the core php file. This is the exactly location
    .....

    Mmmmm, that is certainly not the only place it hurts. All the links to the pages have a (hardcoded) 'http://' in it. So I can open the newly created blogs, but not the pages in them.
    Further, in the "Edit Blog" page for the blogs, the information still shows 'http', and I wouldn't know where to change it.
    In the Edit page itself some fields can be changed (as is often the case with an Edit page), among which the SiteURL or the Home page. When I change these, and refresh the page, the changes turn out not to be stored.

    So, some work really needs to be done for secure sites. It seems though, that the issue mentioned above already has the status 'solved'.

    ...
    That should be changed to some selector which sniffs whether you are using http or https in the next wpmu release
    ....

    That would be the nicest solution, but easier (and quicker) to implement would be checkbox ("Are you using a secured site?"), and have the setting stored in and read from the 'protocol' parameter (or something like that)

    Meanwhile, I have moved my MU to the 'public_html' directory.

  18. DeannaS
    Member
    Posted 14 years ago #

    Where it is being figured out, it's already being read from a constant set in the wp-config directory. If you're finding specific places in the source code where it needs to be changed yet, open a new trac ticket (your same login should work there). Better yet, submit a patch. The intent is to make ssl work on both backend and front.

About this Topic