The MU forums have moved to WordPress.org

Syntax error in kses.php (9 posts)

  1. mshao
    Member
    Posted 17 years ago #

    I just tried to upgrade my site to the latest nightly build. I got this error

    Parse error: syntax error, unexpected ';', expecting ')' in /home/mshao/public_html/wp-includes/kses.php on line 245

    Any suggestions.

    Thanks

  2. mypatricks
    Member
    Posted 17 years ago #

  3. mrjcleaver
    Member
    Posted 17 years ago #

    Perhaps we can get wpmu builds tagged as stable/unstable? There should be a way for people to keep up-to-date without risking being at HEAD.

  4. mshao
    Member
    Posted 17 years ago #

    Thanks for the info. After confirmed by you it's bug, I digged into the code and found about three places missing ")". Here is my update for the code section from line #20 to line #279. Just for your reference.

    if (!CUSTOM_TAGS) {
    $allowedposttags = array (
    'address' => array (),
    'a' => array (
    'class' => array (),
    'href' => array (),
    'id' => array (),
    'title' => array (),
    'rel' => array (),
    'rev' => array (),
    'name' => array (),
    'target' => array()),
    'abbr' => array (
    'title' => array ()),
    'acronym' => array (
    'title' => array ()),
    'b' => array (),
    'big' => array (),
    'blockquote' => array (
    'id' => array (),
    'cite' => array ()),
    'br' => array (
    'class' => array ()),
    'button' => array (
    'disabled' => array (),
    'name' => array (),
    'type' => array (),
    'value' => array ()),
    'caption' => array (
    'align' => array (),
    'class' => array ()),
    'cite' => array (
    'class' => array(),
    'dir' => array(),
    'lang' => array(),
    'title' => array ()),
    'code' => array (),
    'col' => array (
    'align' => array (),
    'char' => array (),
    'charoff' => array (),
    'span' => array (),
    'dir' => array(),
    'valign' => array (),
    'width' => array ()),
    'del' => array (
    'datetime' => array ()),
    'dd' => array (),
    'div' => array (
    'align' => array (),
    'class' => array (),
    'dir' => array ()),
    'dl' => array (),
    'dt' => array (),
    'em' => array (),
    'fieldset' => array (),
    'font' => array (
    'color' => array (),
    'face' => array (),
    'size' => array ()),
    'form' => array (
    'action' => array (),
    'accept' => array (),
    'accept-charset' => array (),
    'enctype' => array (),
    'method' => array (),
    'name' => array (),
    'target' => array ()),
    'h1' => array (
    'align' => array (),
    'class' => array ()),
    'h2' => array (
    'align' => array (),
    'class' => array ()),
    'h3' => array (
    'align' => array (),
    'class' => array ()),
    'h4' => array (
    'align' => array (),
    'class' => array ()),
    'h5' => array (
    'align' => array (),
    'class' => array ()),
    'h6' => array (
    'align' => array (),
    'class' => array ()),
    'hr' => array (
    'align' => array (),
    'class' => array (),
    'noshade' => array (),
    'size' => array (),
    'width' => array ()),
    'i' => array (),
    'iframe' => array ( // This is filtered to whitelisted domains later according to Andy
    'longdesc' => array(),
    'name' => array(),
    'src' => array(),
    'frameborder' => array(),
    'marginwidth' => array(),
    'marginheight' => array(),
    'scroll' => array(),
    'scrolling' => array(),
    'align' => array(),
    'height' => array(),
    'width' => array ()),
    'img' => array (
    'alt' => array (),
    'align' => array (),
    'border' => array (),
    'class' => array (),
    'height' => array (),
    'hspace' => array (),
    'longdesc' => array (),
    'vspace' => array (),
    'src' => array (),
    'width' => array ()),
    'ins' => array (
    'datetime' => array (),
    'cite' => array ()),
    'kbd' => array (),
    'label' => array (
    'for' => array ()),
    'legend' => array (
    'align' => array ()),
    'li' => array (
    'align' => array (),
    'class' => array ()),
    'p' => array (
    'class' => array (),
    'align' => array (),
    'dir' => array()),
    'pre' => array (
    'width' => array ()),
    'q' => array (
    'cite' => array ()),
    's' => array (),
    'span' => array (
    'class' => array (),
    'dir' => array (),
    'align' => array ()),
    'strike' => array (),
    'strong' => array (),
    'sub' => array (),
    'sup' => array (),
    'table' => array (
    'align' => array (),
    'bgcolor' => array (),
    'border' => array (),
    'cellpadding' => array (),
    'cellspacing' => array (),
    'class' => array (),
    'dir' => array(),
    'rules' => array (),
    'summary' => array (),
    'width' => array ()),
    'tbody' => array (
    'align' => array (),
    'char' => array (),
    'charoff' => array (),
    'valign' => array ()),
    'td' => array (
    'abbr' => array (),
    'align' => array (),
    'axis' => array (),
    'bgcolor' => array (),
    'char' => array (),
    'charoff' => array (),
    'class' => array (),
    'colspan' => array (),
    'dir' => array(),
    'headers' => array (),
    'height' => array (),
    'nowrap' => array (),
    'rowspan' => array (),
    'scope' => array (),
    'valign' => array (),
    'width' => array ()),
    'textarea' => array (
    'cols' => array (),
    'rows' => array (),
    'disabled' => array (),
    'name' => array (),
    'readonly' => array ()),
    'tfoot' => array (
    'align' => array (),
    'char' => array (),
    'class' => array (),
    'charoff' => array (),
    'valign' => array ()),
    'th' => array (
    'abbr' => array (),
    'align' => array (),
    'axis' => array (),
    'bgcolor' => array (),
    'char' => array (),
    'charoff' => array (),
    'class' => array (),
    'colspan' => array (),
    'headers' => array (),
    'height' => array (),
    'nowrap' => array (),
    'rowspan' => array (),
    'scope' => array (),
    'valign' => array (),
    'width' => array ()),
    'thead' => array (
    'align' => array (),
    'char' => array (),
    'charoff' => array (),
    'class' => array (),
    'valign' => array ()),
    'title' => array (),
    'tr' => array (
    'align' => array (),
    'bgcolor' => array (),
    'char' => array (),
    'charoff' => array (),
    'class' => array (),
    'valign' => array ()),
    'tt' => array (),
    'u' => array (),
    'ul' => array (
    'class' => array ()),
    'ol' => array (
    'class' => array ()),
    'var' => array ());
    $allowedtags = array (
    'a' => array (
    'href' => array (),
    'title' => array ()),
    'abbr' => array (
    'title' => array ()),
    'acronym' => array (
    'title' => array ()),
    'b' => array (),
    'blockquote' => array (
    'cite' => array ()),
    // 'br' => array(),
    'cite' => array (),
    'code' => array (),
    'del' => array(
    'datetime' => array ()),
    // 'dd' => array(),
    // 'dl' => array(),
    // 'dt' => array(),
    'em' => array (), 'i' => array (),
    // 'ins' => array('datetime' => array(), 'cite' => array()),
    // 'li' => array(),
    // 'ol' => array(),
    // 'p' => array(),
    'q' => array(
    'cite' => array ()),
    'strike' => array (),
    'strong' => array (),
    // 'sub' => array(),
    // 'sup' => array(),
    // 'u' => array(),
    // 'ul' => array(),
    );
    }

  5. pumpkinslayer
    Member
    Posted 17 years ago #

    I only recently started updating using subversion, and it really rocks.

    Syntax errors are not uncommon, but the long turnaround until little bugs are fixed is quite frustrating. Is there noone else besides donncha who can make changes? Or is it possible for someone else to make changes to be approved by donncha?

    Just wondering, can't complain too much about such fantastic and FR*E software. It would be great to spread the load a little. I imagine donncha has his hands pretty full anyway.

  6. mrjcleaver
    Member
    Posted 17 years ago #

    The http://codex.wordpress.org/WPMU_Development_Methodology mirrors that of Wordpress and apparently is not going to change.

    I agree that having a SVN repository that is open might help. You know, we could collaboratively 1) keep it up to date with the wpmu tree and 2) experiment with sharing changes with one another.

    I don't know whether anyone else here thinks it worth the trouble.

  7. drmike
    Member
    Posted 17 years ago #

    I think you, andrew and me MrJ are probably the only ones here who aren't afraid to really hack code though. (Maybe Andrea on a good day)

  8. andrea_r
    Moderator
    Posted 17 years ago #

    :D Ah, Mike, you know me well....

  9. mrjcleaver
    Member
    Posted 17 years ago #

    See http://codex.wordpress.org/WPMU_Forums#Why_use_the_wiki_rather_than_the_forums.3F for an example of other people who have wanted access via SVN. In that case they went to the trouble of setting up a SVN repo for .PO files, but as usual their contribution got lost in the unending stream of conciousness that is this forum.

    The policy of single access to SVN assumes that no one else will come along with sufficient skills and motivation to help code. It also really poisons their ability to get in there and make a difference on the periphery such that the core developers can forge ahead on the core. This is a limit to MU's ability to scale.

    Its only because I have collaborated for so many years on the TWiki wiki that I have sufficient conviction to push ahead (seemingly against the will of those with access to trac wiki) and put my notes on http://codex.wordpress.org/Category:WPMU ; yet my conviction stems from the knowledge that other people WILL FIX UP what I write so that Codex continues to grow manageably in proportion to the number of people who edit it.

    That's more than can be said for the forums. Here people throw in their questions because browsing the forums is so terrible, and the searching mechanism does not serve anyone. All these questions adds to the load on the core group (drmike and Andrea) as the number of people using WPMU increases, with no process for bringing people into the fold such that they are contributors.

    Reading DrMike's friendly reminder - it drove it home to me... people ask experts because the expert is someone who has read everything and has it tied together in the head. These forums do everything to disperse content uncontrollably across topics.

    Only the experts who are here everyday see where everything went.

    Gah. Forums are one hell of a leaky bucket.

    http://codex.wordpress.org/Talk:WPMU_Forums

About this Topic

  • Started 17 years ago by mshao
  • Latest reply from mrjcleaver